chore(react-tags-preview): update stories and best practices for adding aria-label on dismissible tag #29026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit db9e99d:
|
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 405ee3cf4d5bcaae806448be6c497927d4f1730b (build) |
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
YuanboXue-Amber
force-pushed
the
tag-pr1
branch
from
ef03fa7 to
10dfe39
Compare
YuanboXue-Amber
changed the title
bsunderhus
approved these changes
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR update stories of dismissible InteractionTag with proper aria-label/aria-labelledby and add it in best practice guide.
It gives
aria-labelon the dismiss button, and usearia-labelledbyto make it announce the content of the primary button as well, providing more context for screenreader users: